Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[legacy-framework] add prompt to blitz new to choose javascript or typescript #2739

Merged
merged 8 commits into from
Oct 22, 2021

Conversation

beerose
Copy link
Contributor

@beerose beerose commented Sep 24, 2021

Added a language prompt (TypeScript or JavaScript) for the blitz new command.
TS is the default option, and it's still possible to pass the --js flag (it won't show the prompt is a user passed this flag).

What are the changes and their implications?

Bug Checklist

  • Integration test added (see test docs if needed)

Feature Checklist

kodiakhq[bot]
kodiakhq bot previously approved these changes Sep 24, 2021
flybayer
flybayer previously approved these changes Sep 24, 2021
Copy link
Member

@flybayer flybayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but let's wait to merge until all the basics are working with JS

@beerose
Copy link
Contributor Author

beerose commented Sep 27, 2021

Looks good, but let's wait to merge until all the basics are working with JS

Makes sense. By all the basics working, do you mean closing this issue: blitz-js/legacy-framework#462 first?

@flybayer
Copy link
Member

@beerose yeah, blitz generate should work

@beerose beerose dismissed stale reviews from flybayer and kodiakhq[bot] via 76d0e6d October 18, 2021 12:15
kodiakhq[bot]
kodiakhq bot previously approved these changes Oct 18, 2021
kodiakhq[bot]
kodiakhq bot previously approved these changes Oct 21, 2021
@flybayer flybayer changed the title add project language prompt for blitz new command add prompt to blitz new to choose javascript or typescript Oct 21, 2021
@itsdillon itsdillon changed the title add prompt to blitz new to choose javascript or typescript [legacy-framework] add prompt to blitz new to choose javascript or typescript Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants