Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[legacy-framework] Fix internal middleware to use forwarded header to set protocol #2705

Merged
merged 1 commit into from
Sep 10, 2021
Merged

Conversation

kotx
Copy link

@kotx kotx commented Sep 9, 2021

Would close blitz-js/legacy-framework#776, but already closed.

What are the changes and their implications?

The middleware now takes the protocol from the more standard Forwarded header.
I've also added 2 unit tests.

Feature Checklist

@flybayer
Copy link
Member

Thank you!!

@flybayer flybayer changed the title Use forwarded header to set proto Fix internal middleware to use forwarded header to set protocol Sep 10, 2021
@flybayer flybayer merged commit 1e92fe3 into blitz-js:canary Sep 10, 2021
@blitzjs-bot
Copy link
Contributor

Added @kotx contributions for code and test

@itsdillon itsdillon changed the title Fix internal middleware to use forwarded header to set protocol [legacy-framework] Fix internal middleware to use forwarded header to set protocol Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to find request token in session when twitter login and using Nginx proxy
3 participants