Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[legacy-framework] fix route manifest for mdx pages #2678

Merged
merged 1 commit into from
Aug 27, 2021
Merged

[legacy-framework] fix route manifest for mdx pages #2678

merged 1 commit into from
Aug 27, 2021

Conversation

flybayer
Copy link
Member

What are the changes and their implications?

Fix a bug where mdx files caused the route manifest generation to fail the build.

Now the route manifest for mdx files is a PascalCase version of the route path instead of trying to parse a default export name.

mdx routes:
/               -> Routes.Index()
/home           -> Routes.Home()
/docs/two-words -> Routes.DocsTwoWords()

Bug Checklist

  • Integration test added (see test docs if needed)

@flybayer flybayer merged commit 294bcd2 into canary Aug 27, 2021
@flybayer flybayer deleted the mdx branch August 27, 2021 20:50
@itsdillon itsdillon changed the title fix route manifest for mdx pages [legacy-framework] fix route manifest for mdx pages Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants