Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[legacy-framework] Fix usage with pnpm #2673

Merged
merged 13 commits into from
Aug 27, 2021
Merged

[legacy-framework] Fix usage with pnpm #2673

merged 13 commits into from
Aug 27, 2021

Conversation

flybayer
Copy link
Member

@flybayer flybayer commented Aug 26, 2021

Closes: blitz-js/legacy-framework#149
Closes: blitz-js/legacy-framework#964

What are the changes and their implications?

Fixes Blitz to work with pnpm! Should also allow it to work with yarn PnP, etc.

You need to add the following to .npmrc for pnpm.

public-hoist-pattern[]=next
public-hoist-pattern[]=secure-password
public-hoist-pattern[]=*jest*
public-hoist-pattern[]=@testing-library/*

kodiakhq[bot]
kodiakhq bot previously approved these changes Aug 26, 2021
kodiakhq[bot]
kodiakhq bot previously approved these changes Aug 26, 2021
kodiakhq[bot]
kodiakhq bot previously approved these changes Aug 26, 2021
@flybayer flybayer merged commit 4320589 into canary Aug 27, 2021
@flybayer flybayer deleted the pnpm branch August 27, 2021 16:01
@itsdillon itsdillon changed the title Fix usage with pnpm [legacy-framework] Fix usage with pnpm Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Error: Cannot find module 'blitz'" when installing with volta Dependencies missing prevents pnpm working
2 participants