Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[legacy-framework] Convert app template Jest config to TypeScript #2663

Merged
merged 4 commits into from
Aug 30, 2021

Conversation

ratson
Copy link

@ratson ratson commented Aug 21, 2021

What are the changes and their implications?

This enables code completion.

Feature Checklist

@flybayer
Copy link
Member

Thanks @ratson! This seems reasonable for TS users. However, as is, this breaks support for JS users (blitz new myapp --js). You'll need to take the same approach here as we do for jsconfig.json and tsconfig.json

@ratson
Copy link
Author

ratson commented Aug 27, 2021

@flybayer Updated to support JS config.

@flybayer
Copy link
Member

Awesome, thank you!!

@flybayer flybayer merged commit 962b521 into blitz-js:canary Aug 30, 2021
@blitzjs-bot
Copy link
Contributor

Added @ratson contributions for code

@itsdillon itsdillon changed the title Convert app template Jest config to TypeScript [legacy-framework] Convert app template Jest config to TypeScript Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants