Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[legacy-framework] Fix RedirectError incorrectly failing Cypress tests #2655

Merged
merged 1 commit into from
Aug 18, 2021
Merged

[legacy-framework] Fix RedirectError incorrectly failing Cypress tests #2655

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions nextjs/packages/next/client/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,27 @@ if (process.env.NODE_ENV === 'development') {
}
}
window.addEventListener('error', onUnhandledError)

if ('Cypress' in window) {
// Hide some errors from Cypress, so they don't fail Cypress tests
// https://github.com/cypress-io/cypress/issues/7196

const cypressOnErrorFun = window.onerror

window.onerror = (message, source, lineno, colno, err) => {
if (
cypressOnErrorFun &&
!(
err instanceof RedirectError ||
err instanceof AuthenticationError ||
err instanceof AuthorizationError ||
err instanceof NotFoundError
)
) {
cypressOnErrorFun(message, source, lineno, colno, err)
}
}
}
}

if (process.env.__NEXT_I18N_SUPPORT) {
Expand Down