Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[legacy-framework] Fix so that npm scripts don't run on blitz install recipes #2498

Merged
merged 2 commits into from
Jun 19, 2021
Merged

[legacy-framework] Fix so that npm scripts don't run on blitz install recipes #2498

merged 2 commits into from
Jun 19, 2021

Conversation

prisis
Copy link
Contributor

@prisis prisis commented Jun 17, 2021

Closes: blitz-js/legacy-framework#139

What are the changes and their implications?

disable scripts on blitz install

Bug Checklist

  • Integration test added (see test docs if needed)

Feature Checklist

@prisis
Copy link
Contributor Author

prisis commented Jun 17, 2021

@flybayer are test needed for this case?

@prisis prisis marked this pull request as ready for review June 18, 2021 19:10
@prisis prisis requested a review from flybayer as a code owner June 18, 2021 19:10
@flybayer
Copy link
Member

Nope, this is good. Thanks!

@flybayer flybayer changed the title feat: disable scripts on blitz install Fix so that npm scripts don't run on blitz install recipes Jun 19, 2021
@flybayer flybayer merged commit c9dba04 into blitz-js:canary Jun 19, 2021
@blitzjs-bot
Copy link
Contributor

Added @prisis contributions for code

@itsdillon itsdillon changed the title Fix so that npm scripts don't run on blitz install recipes [legacy-framework] Fix so that npm scripts don't run on blitz install recipes Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable scripts on blitz install
3 participants