Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[legacy-framework] Fix webpack 5 support (Webpack 5 now used by default) (patch) #2453

Merged
merged 13 commits into from
Jun 8, 2021

Conversation

flybayer
Copy link
Member

@flybayer flybayer commented Jun 4, 2021

Closes: blitz-js/legacy-framework#285

What are the changes and their implications?

This removes our with-blitz wrapper by moving our default config items into nextjs core

kodiakhq[bot]
kodiakhq bot previously approved these changes Jun 4, 2021
kodiakhq[bot]
kodiakhq bot previously approved these changes Jun 4, 2021
@flybayer flybayer added the 0 - <(^_^)> - merge it! ✌️ Kodiak automerge label Jun 4, 2021
kodiakhq[bot]
kodiakhq bot previously approved these changes Jun 7, 2021
kodiakhq[bot]
kodiakhq bot previously approved these changes Jun 7, 2021
@kodiakhq kodiakhq bot removed the 0 - <(^_^)> - merge it! ✌️ Kodiak automerge label Jun 8, 2021
@kodiakhq
Copy link
Contributor

kodiakhq bot commented Jun 8, 2021

This PR currently has a merge conflict. Please resolve this and then re-add the 0 - <(^_^)> - merge it! ✌️ label.

kodiakhq[bot]
kodiakhq bot previously approved these changes Jun 8, 2021
kodiakhq[bot]
kodiakhq bot previously approved these changes Jun 8, 2021
kodiakhq[bot]
kodiakhq bot previously approved these changes Jun 8, 2021
kodiakhq[bot]
kodiakhq bot previously approved these changes Jun 8, 2021
@flybayer flybayer merged commit a510bd0 into canary Jun 8, 2021
@flybayer flybayer deleted the blitz-config branch June 8, 2021 17:31
@itsdillon itsdillon changed the title Fix webpack 5 support (Webpack 5 now used by default) (patch) [legacy-framework] Fix webpack 5 support (Webpack 5 now used by default) (patch) Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot run Blitz with Webpack 5
3 participants