[legacy-framework] Deserialize SuperJSON-ed pageProps before passing to dehydratedState #2281
Conversation
|
@MrLeebo do you want to add an integration test to this? |
|
@Skn0tt Added a test for this. If you inspect the server rendered output from the integration test, (via running |
|
|
||
| function Bomb() { | ||
| useEffect(() => { | ||
| throw new Error("💣") |
|
Updated to the new |
| ;[].forEach.call(webpackConfig.module.rules, function ( | ||
| rule: webpack.RuleSetRule | ||
| ) { | ||
| if (!(rule.test instanceof RegExp && Array.isArray(rule.use))) { | ||
| return | ||
| } | ||
| ;[].forEach.call( | ||
| webpackConfig.module.rules, | ||
| function (rule: webpack.RuleSetRule) { | ||
| if (!(rule.test instanceof RegExp && Array.isArray(rule.use))) { | ||
| return | ||
| } |
There was a problem hiding this comment.
Can we revert all the changes to the nextjs/* files? Not sure how this happened, but it will cause merge conflicts with the fork.
|
And you have a build error |
|
I'm currently playing around with query prefetching, and my query results include date objects. In this case, I receive a serialization error as this object is being handled by next. |
|
@nimashoghi oops — can you open a new issue for that? |
itsdillon
changed the title
Closes: blitz-js/legacy-framework#89
What are the changes and their implications?
When
pagePropsis accessed, it's required to deserialize its contents before using them.Bug Checklist
Feature Checklist