Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[legacy-framework] Enable proxy support for cli/install #2264

Merged
merged 3 commits into from
Apr 24, 2021

Conversation

mubaidr
Copy link

@mubaidr mubaidr commented Apr 23, 2021

Closes: blitz-js/legacy-framework#115

What are the changes and their implications?

More info:
blitz-js/legacy-framework#115

Bug Checklist

  • Integration test added (see test docs if needed)

Feature Checklist

@mubaidr
Copy link
Author

mubaidr commented Apr 23, 2021

Documentation update pull request: blitz-js/blitzjs.com#454

@mubaidr mubaidr marked this pull request as ready for review April 23, 2021 17:31
@mubaidr mubaidr requested a review from flybayer as a code owner April 23, 2021 17:31
@flybayer
Copy link
Member

Sweet, thank you!!

@flybayer flybayer merged commit 92f769d into blitz-js:canary Apr 24, 2021
@blitzjs-bot
Copy link
Contributor

Added @mubaidr contributions for code

flybayer added a commit to blitz-js/blitzjs.com that referenced this pull request Apr 27, 2021
ghost pushed a commit to blitz-js/id.blitzjs.com that referenced this pull request Jul 10, 2021
* updated prisma migrate usage in docs (#419)

Co-authored-by: JuanM04 <[email protected]>
Co-authored-by: Andreas Bollig <[email protected]>
Co-authored-by: Abu Uzayr <[email protected]>
Co-authored-by: François Best <[email protected]>
Co-authored-by: Faraz Patankar <[email protected]>
Co-authored-by: Eric Vicenti <[email protected]>
Co-authored-by: Alex <[email protected]>

* Update docs for upgrade to React Query v3 (#424)

Co-authored-by: JuanM04 <[email protected]>
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
Co-authored-by: Brandon Bayer <[email protected]>
Co-authored-by: Andreas Bollig <[email protected]>
Co-authored-by: Abu Uzayr <[email protected]>
Co-authored-by: François Best <[email protected]>
Co-authored-by: Faraz Patankar <[email protected]>
Co-authored-by: Eric Vicenti <[email protected]>
Co-authored-by: Layne Geck <[email protected]>
Co-authored-by: gstranger <[email protected]>
Co-authored-by: Andrea Rizzello <[email protected]>

* Document Routes Manifest (#430)

Co-authored-by: Brandon Bayer <[email protected]>
Co-authored-by: Jahred Hope <[email protected]>
Co-authored-by: Fran Zekan <[email protected]>

* Updated dependencies

* Uppercased "admin" in session-management.mdx (#441)

* Few maintainers retire

* Add myself as L1 Maintainer (#443)

* Fix the first two issues of #436 (#439)

* Edit Dieman's personal website (#445)

* update hero code sample to use new Routes object

* new maintainer TommasoBruno added (#444)

* new maintainer TommasoBruno added

* href TommasoBruno maintainer changed

* Added `--inspect` flag to CLI (#447)

Added to `cli-start.mdx` & `cli-dev.mdx`

* Fix minor typo in query-usage.mdx (#449)

* Added a note about broken symlinks

* Typo in contributing.mdx

* Improve deploy-vercel.mdx consistency and clarity (#450)

* Upgraded dependencies

* Remove Anonymous Functions Exports  (#451)

* typo fix

Small typo fix:
you'll need to do the
chech
=>
you'll need to do the
check

* Update session.create > session.$create

* Update api routes doc examples - no anon exports

* Edit preview mode doc examples - no anon exports

* Change export name to handler

* Change export name to handler

* Added BlitzApiHandler

* Update contributing.mdx

* add RIT as sponsor

* Added description to `useInfiniteQuery` and `usePaginatedQuery` (#453)

* update docs for server.ts

* Update get-started.mdx

* Formatted docs

* Updated dependencies

* Fix typo tutorial.mdx (#458)

Typo removed

* Admonitions --> Cards (#456)

* Recommend customTsParser for building a new recipe (#455)

* add info for proxy-support blitz-js/blitz#2264 (#454)

Co-authored-by: Brandon Bayer <[email protected]>

* Documentation for new schema.prisma transform utilities (#457)

Co-authored-by: Brandon Bayer <[email protected]>

* Extend "run postgres via docker" section (#460)

* add multitenancy doc page

* update query and mutation docs to reflect latest recommendations

* add example of creating entity to multitenancy page

* update docs for blitz.config.ts

* update docs for nextjs 10.2

* another update

* Changed Prettier config to match new app config

* Add `scroll-behavior: smooth;` to main.css (#461)

This commit is rather simple. It simply makes the scrolling when you scroll by id much smoother. For example, when you use the Back to top button in the footer, it won't jump up so quickly, it'll instead scroll. This is useful because it will surprise people less and it'll seem cleaner and less choppy too.

* Update use-paginated-query.mdx

* Update use-infinite-query.mdx

* Create guide to deploy to Railway (#462)

Co-authored-by: JuanM04 <[email protected]>

* fix tutorial

* update link

* Update done method in passportjs.mdx (#464)

* Update use-infinite-query.mdx

* Fix typo in tutorial.mdx (#467)

* fix build

* Toggling text and removing outline (#469)

Co-authored-by: Brandon Bayer <[email protected]>

* Update query-usage.mdx

* add docs for setting up node.js

* Documentation about prefetching and dehydratedState (#465)

* improve custom server doc

* Fixes import path for useCurrentUser in authorization.mdx (#471)

* Update session-management.mdx

* Images optimization (#474)

* typo fix

Small typo fix:
you'll need to do the
chech
=>
you'll need to do the
check

* Update session.create > session.$create

* Update api routes doc examples - no anon exports

* Edit preview mode doc examples - no anon exports

* Change export name to handler

* Change export name to handler

* lazy load random contributor images

* lazy load appropriate player, url

* switch to Image tag

* fix image sizing

* change user track image to github url

* make layout intrinsic

Co-authored-by: Roshan Manuel <Roshan,[email protected]>

* redirectAuthenticatedTo with Routes Manifest in authorization.mdx (#475)

* Typo in tradeoffs.mdx (#477)

* Update query-usage.mdx

* Documentation Improvement: Page.authenticate implies Page.suppressFirstRenderFlicker (#476)

* add cookie prefix to docs

* Document authenticate.redirectTo: RouteManifest (#479)

* Add doc page for eslint config and fix typo (#478)

Co-authored-by: Roshan Manuel <Roshan,[email protected]>

* Missing import (#480)

If you try to copy-paste the examples there's a missing import

* Avoid hardcoding "admin" role during impersonation (#481)

When you impersonate another use it would be a good idea to assumer their role too.

Most endpoints will be protected with some for of authorizer e.g. `resolver.authorize("seller")` or `resolver.authorize("buyer")`. 
If you try and invoke these endpoints as an admin, they all need to be changed to `resolver.authorize(["seller", "admin"])` or `resolver.authorize(["buyer", "admin"])` etc.

If you assume the role of the user you're impersonating, you don't need to change anything.

In terms of security: 
- `startImpersonating` should only be available to admins, so it should be secured with `resolver.authorize("admin")`.
- we can allow `stopImpersonating` to be called without a role restriction as it is: the code already checks if `impersonatingFromUserId` is present in the session. If present, the user simply regains whatever role they had before ("admin", "support", etc), otherwise the endpoint is no-op.

* `resolver.authorize` description at resolver-server-utilities.mdx (#484)

* Fix theme toggle (#485)

* Add doc page for prettier config (#482)

Co-authored-by: Roshan Manuel <Roshan,[email protected]>

* Husky doc (#487)

Co-authored-by: Roshan Manuel <Roshan,[email protected]>
Co-authored-by: JuanM04 <[email protected]>
Co-authored-by: Brandon Bayer <[email protected]>

* Fix typo at testing.mdx (#489)

* update docs for nextjs 10.2.3

* Expanded getQueryKey and invalidateQuery at resolver-client-utilities.mdx (#492)

* add some comments to getQueryKey and invalidateQuery

* add link to react query docs

* Add bilaterial reference between dynamic routing and useParam/useRouterQuery (#491)

* Add usecase "dynamic routing"

* Add reference to useParams, useParam and useRouterQuery

* typo, move link at useParams and useParam

* Test database notes (#493)

* add test database to postgres docker docs

* clarified that test db must be different than main

* feat: add documentation for customServer.hotReload (#495)

Co-authored-by: Roshan Manuel <Roshan,[email protected]>
Co-authored-by: JuanM04 <[email protected]>
Co-authored-by: Brandon Bayer <[email protected]>
Co-authored-by: Roshan Manuel <[email protected]>
Co-authored-by: Francesco Sardo <[email protected]>
Co-authored-by: Antony Kamp <[email protected]>
Co-authored-by: Nikolay <[email protected]>
Co-authored-by: Andreas Thomas <[email protected]>
Co-authored-by: Marek Orłowski <[email protected]>

* Typo in API routes documentation (#496)

* fix build

* update 1.0 expectation date

* adds documentation for utility functions (#498)

Co-authored-by: Brandon Bayer <[email protected]>

* docs: document new setPublicDataForUser API (#500)

Co-authored-by: Brandon Bayer <[email protected]>
Co-authored-by: Lukas Neumann <[email protected]>

* adds documentation for utility functions (#498) (#502)

* add docs for RedirectError

* Clarify distinction between useSession & useCurrentUser (#501)

* Update mutation-resolvers.mdx (#503)

* add docs for nextjs 11 (#504)

* add docs for formatZodError

* Upgrade blitz and to react 18 (#505)

* Add instruction for render.yaml (#507)

* Adds builder.printMessage documentation (#508)

Co-authored-by: Nicolas <[email protected]>

* Update font-optimization.mdx

* Update prismjs to version 1.24.0 (#510)

* update docs for nextjs 11

* fix build

* Bump ws from 7.4.3 to 7.5.0 (#506)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Co-authored-by: Alex Dolan <[email protected]>
Co-authored-by: JuanM04 <[email protected]>
Co-authored-by: Andreas Bollig <[email protected]>
Co-authored-by: Abu Uzayr <[email protected]>
Co-authored-by: François Best <[email protected]>
Co-authored-by: Faraz Patankar <[email protected]>
Co-authored-by: Eric Vicenti <[email protected]>
Co-authored-by: Alex <[email protected]>
Co-authored-by: Brandon Bayer <[email protected]>
Co-authored-by: tundera <[email protected]>
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
Co-authored-by: Layne Geck <[email protected]>
Co-authored-by: gstranger <[email protected]>
Co-authored-by: Andrea Rizzello <[email protected]>
Co-authored-by: Simon Knott <[email protected]>
Co-authored-by: Jahred Hope <[email protected]>
Co-authored-by: Fran Zekan <[email protected]>
Co-authored-by: sean-brydon <[email protected]>
Co-authored-by: Alessandro <[email protected]>
Co-authored-by: laubonghaudoi <[email protected]>
Co-authored-by: Alessandro <[email protected]>
Co-authored-by: Tommaso Bruno <[email protected]>
Co-authored-by: Antony <[email protected]>
Co-authored-by: Justin Hall <[email protected]>
Co-authored-by: Fatih Altinok <[email protected]>
Co-authored-by: Roshan Manuel <[email protected]>
Co-authored-by: Antony <[email protected]>
Co-authored-by: mlabate <[email protected]>
Co-authored-by: Tom MacWright <[email protected]>
Co-authored-by: Muhammad Ubaid Raza <[email protected]>
Co-authored-by: Jeremy Liberman <[email protected]>
Co-authored-by: DawnOfMidnight <[email protected]>
Co-authored-by: Kevin Østerkilde <[email protected]>
Co-authored-by: meepdeew <[email protected]>
Co-authored-by: Hardik Gaur <[email protected]>
Co-authored-by: craigglennie <[email protected]>
Co-authored-by: Roshan Manuel <Roshan,[email protected]>
Co-authored-by: swiftgaruda <[email protected]>
Co-authored-by: Pankaj Patil <[email protected]>
Co-authored-by: Francesco Sardo <[email protected]>
Co-authored-by: Nikolay <[email protected]>
Co-authored-by: Andreas Thomas <[email protected]>
Co-authored-by: Marek Orłowski <[email protected]>
Co-authored-by: Mark Hughes <[email protected]>
Co-authored-by: garnerp <[email protected]>
Co-authored-by: Sean Winner <[email protected]>
Co-authored-by: Lukas Neumann <[email protected]>
Co-authored-by: Lukas Neumann <[email protected]>
Co-authored-by: Dustin Bachrach <[email protected]>
Co-authored-by: Daniel Almaguer <[email protected]>
Co-authored-by: Kevin Peters <[email protected]>
Co-authored-by: Nicolas Torres <[email protected]>
Co-authored-by: Nicolas <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@itsdillon itsdillon changed the title Enable proxy support for cli/install [legacy-framework] Enable proxy support for cli/install Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Blitz unable to find/install any recipe when using a proxy
3 participants