Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[legacy-framework] Fix crash when using Blitz inside iframes #2219

Merged
merged 1 commit into from
Apr 14, 2021

Conversation

mtford90
Copy link

@markhughes
Copy link

Also seems recommended on MDN:

setItem() may throw an exception if the storage is full. Particularly, in Mobile Safari (since iOS 5) it always throws when the user enters private mode. (Safari sets the quota to 0 bytes in private mode, unlike other browsers, which allow storage in private mode using separate data containers.) Hence developers should make sure to always catch possible exceptions from setItem().

see: https://developer.mozilla.org/en-US/docs/Web/API/Storage/setItem

@flybayer
Copy link
Member

Sweet, thanks!!

@flybayer flybayer changed the title Fix issue whereby Blitz apps could not run in certain iframe contexts where localStorage is unavailable Fix crash when using Blitz inside iframes Apr 14, 2021
@flybayer flybayer merged commit ec5cc08 into blitz-js:canary Apr 14, 2021
@itsdillon itsdillon changed the title Fix crash when using Blitz inside iframes [legacy-framework] Fix crash when using Blitz inside iframes Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Blitz apps crash when run in an iFrame in Chrome when third-party cookies are disabled
4 participants