Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[legacy-framework] Fix shallow routing #2173

Merged
merged 1 commit into from
Mar 31, 2021
Merged

[legacy-framework] Fix shallow routing #2173

merged 1 commit into from
Mar 31, 2021

Conversation

sakulstra
Copy link

@sakulstra sakulstra commented Mar 30, 2021 •
edited
Loading

@sakulstra sakulstra changed the title fix: another potential fix fix: fix shallow routing Mar 30, 2021
@sakulstra
Copy link
Author

sakulstra commented Mar 30, 2021 •
edited
Loading

not sure if broken tests are related to my changes or not.
Cannot reproduce locally, so it might be flakiness, but idk...

      │ Test Suites: 20 passed, 20 total
      │ Tests:       2 skipped, 78 passed, 80 total
      │ Snapshots:   11 passed, 11 total
      │ Time:        35.628 s
      │ Ran all test suites.

@flybayer
Copy link
Member

Very nice, thank you!

@flybayer flybayer changed the title fix: fix shallow routing Fix shallow routing Mar 31, 2021
@flybayer flybayer merged commit a26fdd8 into blitz-js:canary Mar 31, 2021
@flybayer flybayer mentioned this pull request Mar 31, 2021
Closed
@itsdillon itsdillon changed the title Fix shallow routing [legacy-framework] Fix shallow routing Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
status/done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Blitz breaks Shallow Routing of Next.js
3 participants
@sakulstra @flybayer @blitzjs-bot