Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[legacy-framework] Fix quirrel install recipe #2170

Merged
merged 15 commits into from
Mar 31, 2021
Merged

[legacy-framework] Fix quirrel install recipe #2170

merged 15 commits into from
Mar 31, 2021

Conversation

roshan-sama
Copy link
Collaborator

@roshan-sama roshan-sama commented Mar 30, 2021 •
edited
Loading

Closes: ??

What are the changes and their implications?

Updating the install command to update the development script instead of the production script since the blitz start command changed to be the production one.
In addition, updating the installer to add double quotes around the original command to avoid this issue:

$ concurrently --raw 'blitz dev' 'quirrel'
''blitz' is not recognized as an internal or external command,
operable program or batch file.
'dev'' is not recognized as an internal or external command,
operable program or batch file.

Checklist

  • Changes covered by tests (tests added if needed)
  • Does this PR warrant documentation updates? If yes, open a second PR with doc changes to blitzjs.com

roshan-sama and others added 15 commits February 28, 2021 20:52
@roshan-sama
don't throw an error if checkYarn is null or checkYarn.stdout is null…
a651c0b 
… or undefined
@roshan-sama
make sure to check if this version is less than the latest version
55c6afa
@roshan-sama
Merge pull request #1 from blitz-js/canary
6399d86 
March 5 pull request
@roshan-sama
Merge pull request #2 from blitz-js/canary
db307ca 
Pull from blitz-js
fix forgotpassword test template, sync auth example tests
71285b5
@flybayer
Merge branch 'canary' into canary
cd2bdca
@roshan-sama
revert to ensure monorepo tests work
8ea14c9
revert to original password and index tests
88de5c5
Merge branch 'canary' of https://github.com/Roesh/blitz into canary
321e963
@roshan-sama
remove merge reference
2e17e47
fix merge issue
650d285
Merge branch 'canary' of https://github.com/Roesh/blitz into canary
b484fe7
@roshan-sama
Merge pull request #3 from blitz-js/canary
8e78e4b 
Pull latest blitz version
Merge branch 'canary' of https://github.com/Roesh/blitz into canary
97ad3be
Quirrel recipe: start > dev, double quote command
e4ab177
@Skn0tt Skn0tt self-requested a review March 30, 2021 15:18
Skn0tt
Skn0tt approved these changes Mar 30, 2021
View reviewed changes
Copy link
Member

@Skn0tt Skn0tt left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Nice PR @roesh!

@flybayer flybayer changed the title Update quirrel install recipe Fix quirrel install recipe Mar 31, 2021
@flybayer flybayer merged commit f40c0f0 into blitz-js:canary Mar 31, 2021
@itsdillon itsdillon changed the title Fix quirrel install recipe [legacy-framework] Fix quirrel install recipe Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Skn0tt Skn0tt Skn0tt approved these changes

Assignees
No one assigned
Labels
status/done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@roshan-sama @Skn0tt @flybayer @blitzjs-bot