[legacy-framework] Switch to using @blitz/installer helper functions … #2164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng logic in each recipe.
MrLeebo
previously approved these changes
Mar 29, 2021
|
Sweet, thanks @kevinlangleyjr! Can you resolve the one merge conflict? |
wKovacs64
reviewed
Mar 29, 2021
| @@ -124,7 +107,7 @@ export default RecipeBuilder() | |||
| explanation: `Update the Babel configuration to use Emotion's plugin and preset to enable some advanced features.`, | |||
| singleFileSearch: paths.babelConfig(), | |||
| transform(program: Collection<j.Program>) { | |||
| addBabelPlugin(program) | |||
| addBabelPlugin(program, "@emotion") | |||
There was a problem hiding this comment.
Oops, I totally missed this in #2156. Glad to see it'll be fixed here. 👍
There was a problem hiding this comment.
@wKovacs64 I saw your PR right after I submitted mine! 🙂
|
Merge conflict resolved @flybayer! 🙂 🚀 |
itsdillon
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes and their implications?
Switch to using
@blitz/installerhelpers instead of duplicating logic in each recipe.Checklist