-
-
Notifications
You must be signed in to change notification settings - Fork 801
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[legacy-framework] (meta) fix ultra scripts so they work on Windows #2154
Conversation
Size Change: 0 B Total Size: 233 kB ℹ️ View Unchanged
|
The irony of this change only failing on the Windows image in CI is palpable. |
lol, looks like it failed on both. Do you know why? Maybe just flaky CI? |
Yeah, flaky CI afaict. It only failed on Windows the first time, then when I re-ran the jobs it failed on others, too. 🤷♂️ |
I'm confused because other PRs are not having this test failure 🤔 |
I'm a bit perplexed by it as well, especially since it's just changing quotes and those commands are obviously still executing. Although another PR that was just merged was passing pre-merge and failed post-merge (on a different test, though) so I'm not sure how confident I am in CI at the moment. 🤷♂️ |
Closes: N/A
What are the changes and their implications?
Single quotes in package.json scripts don't work in Windows like you'd expect. Because... Windows. This just replaces them with escaped double quotes.
Checklist