Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[legacy-framework] use decodeURIComponent for router.query.next during page authentication redirect #2114

Merged
merged 4 commits into from
Mar 17, 2021
Merged

[legacy-framework] use decodeURIComponent for router.query.next during page authentication redirect #2114

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0185f1c
use decodeURIComponent to fix bug where slashes in url path were not …
remjx Mar 14, 2021
a1d5934
handle decodeURIComponent(undefined) case
remjx Mar 16, 2021
1464151
fix type error
remjx Mar 16, 2021
240c1ca
Merge branch 'canary' into update-redirect-logic-in-examples
flybayer Mar 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/auth/app/auth/pages/login.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ const LoginPage: BlitzPage = () => {
<div>
<LoginForm
onSuccess={() => {
const next = (router.query.next as string) ?? "/"
const next = router.query.next ? decodeURIComponent(router.query.next as string) : "/"
router.push(next)
}}
/>
Expand Down
2 changes: 1 addition & 1 deletion packages/generator/templates/app/app/auth/pages/login.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ const LoginPage: BlitzPage = () => {
<div>
<LoginForm
onSuccess={() => {
const next = (router.query.next as string) ?? "/"
const next = router.query.next ? decodeURIComponent(router.query.next as string) : "/"
router.push(next)
}}
/>
Expand Down