[legacy-framework] Fix typescript jest issue in forgotPassword.test.ts
#2110
Conversation
March 5 pull request
Pull from blitz-js
| jest.mock("@blitzjs/core/server", () => ({ | ||
| ...jest.requireActual("@blitzjs/core/server")!, | ||
| jest.mock("blitz", () => ({ | ||
| ...jest.requireActual<object>("blitz")!, |
There was a problem hiding this comment.
Thanks @roesh!
You have to actually revert this change as it breaks example tests here in the monorepo. Maybe a way to fix it, but needs to be @blitzjs/core/server for now
There was a problem hiding this comment.
Ah, got it. Let me revert that
| import {render} from "test/utils" | ||
| import { render } from "test/utils" | ||
|
|
||
| import Home from "./index" | ||
| import { useCurrentUser } from "app/core/hooks/useCurrentUser" | ||
|
|
||
| jest.mock("@blitzjs/core", () => ({ | ||
| ...jest.requireActual("@blitzjs/core")!, | ||
| useQuery: () => [ | ||
| { | ||
| id: 1, | ||
| name: "User", | ||
| email: "[email protected]", | ||
| role: "user", | ||
| }, | ||
| ], | ||
| })) | ||
| jest.mock("app/core/hooks/useCurrentUser") | ||
| const mockUseCurrentUser = useCurrentUser as jest.MockedFunction<typeof useCurrentUser> | ||
|
|
||
| test("renders blitz documentation link", () => { | ||
| // This is an example of how to ensure a specific item is in the document | ||
| // But it's disabled by default (by test.skip) so the test doesn't fail | ||
| // when you remove the the default content from the page | ||
|
|
||
| // This is an example on how to mock api hooks when testing | ||
| mockUseCurrentUser.mockReturnValue({ | ||
| id: 1, | ||
| name: "User", | ||
| email: "[email protected]", | ||
| role: "user", | ||
| }) | ||
|
|
||
| const {getByText} = render(<Home />) | ||
| const element = getByText(/powered by blitz/i) | ||
| // @ts-ignore | ||
| expect(element).toBeInTheDocument() | ||
| const { getByText } = render(<Home />) | ||
| const linkElement = getByText(/Documentation/i) | ||
| expect(linkElement).toBeInTheDocument() | ||
| }) |
There was a problem hiding this comment.
So some change in this file is still causing tests to fail.
Not sure if jest.mock needs to be before the import?
There was a problem hiding this comment.
Ah I see. Should the test syncing be a separate PR then? I can commit just the single change to satisfy typescript and we can update the auth tests later?
Also I'm actually not sure how to trigger the CI/CD tests, is there a way to retrigger them and check if the changes I made are OK in the monorepo?
There was a problem hiding this comment.
it's up to you. If we get tests passing, then fine to keep the change here.
CI auto runs on each git push, but you can run these failing tests locally by running yarn jest inside examples/auth
There was a problem hiding this comment.
Ah, I see. I reverted back to the original tests, with the only change being the <object> before their jest.requireActual reference. I tried to troubleshoot the index.test.tsx file but I'm actually ran into issues with the forgotpassword mutation as well, so I reverted that back to its original version too. I made sure to run yarn jest this time and all tests passed.
EDIT: Lint failed, I have to make sure I run that too, let me to that
There was a problem hiding this comment.
Ok, that was on me, I forgot to push the changes I'd made after resolving a merge conflict, I reran the yarn jest command and eslint --fix and lint, and those passed and waiting for the results of the CI tests
|
Thank you!! |
flybayer
changed the title
forgotPassword.test.ts
|
Added @roesh contributions for test |
itsdillon
changed the title
forgotPassword.test.tsforgotPassword.test.ts
Closes: blitz-js/legacy-framework#188
What are the changes and their implications?
Modified ...jest.requireActual("blitz")!,to ...jest.requireActual("blitz")!, to prevent typescript compiler from throwing error.
Using the for now, I tried to get the type of that object using a console log but it said "object" as well, but if there's a better type to assign here sometime in the future, we can swap object out with that instead.
console.log(typeof jest.requireActual("@blitzjs/core/server")!)
Console
console.log
object
at app/auth/mutations/forgotPassword.test.ts:12:11
In addition, I also updated the auth examples tests files to be the same as the templates test files
Checklist