Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[legacy-framework] Fix duplicated Set-Cookie header #2109

Merged
merged 1 commit into from
Mar 15, 2021

Conversation

JuanM04
Copy link

@JuanM04 JuanM04 commented Mar 13, 2021

Closes: blitz-js/legacy-framework#406

What are the changes and their implications?

This changes the setCookie function in sessions.ts. Instead of just appending a cookie header to Set-Cookie, it looks for duplicates. It shouldn't break anything

Checklist

  • Changes covered by tests (tests added if needed)
  • PR submitted to blitzjs.com for any user facing changes

@github-actions
Copy link
Contributor

Size Change: +485 B (0%)

Total Size: 231 kB

Filename Size Change
packages/core/server/dist/blitzjs-core-server.cjs.dev.js 13.4 kB +165 B (+1%)
packages/core/server/dist/blitzjs-core-server.cjs.prod.js 13.4 kB +160 B (+1%)
packages/core/server/dist/blitzjs-core-server.esm.js 13.3 kB +160 B (+1%)
ℹ️ View Unchanged
Filename Size Change
packages/babel-preset/dist/blitzjs-babel-preset.cjs.dev.js 1.69 kB 0 B
packages/babel-preset/dist/blitzjs-babel-preset.cjs.js 150 B 0 B
packages/babel-preset/dist/blitzjs-babel-preset.cjs.prod.js 1.69 kB 0 B
packages/babel-preset/dist/blitzjs-babel-preset.esm.js 1.63 kB 0 B
packages/blitz/cli/dist/blitz-cli.cjs.dev.js 1.47 kB 0 B
packages/blitz/cli/dist/blitz-cli.cjs.js 142 B 0 B
packages/blitz/cli/dist/blitz-cli.cjs.prod.js 1.47 kB 0 B
packages/blitz/cli/dist/blitz-cli.esm.js 1.37 kB 0 B
packages/blitz/custom-server/dist/blitz-custom-server.cjs.dev.js 288 B 0 B
packages/blitz/custom-server/dist/blitz-custom-server.cjs.js 149 B 0 B
packages/blitz/custom-server/dist/blitz-custom-server.cjs.prod.js 288 B 0 B
packages/blitz/custom-server/dist/blitz-custom-server.esm.js 123 B 0 B
packages/blitz/dist/blitz.cjs.dev.js 355 B 0 B
packages/blitz/dist/blitz.cjs.js 139 B 0 B
packages/blitz/dist/blitz.cjs.prod.js 355 B 0 B
packages/blitz/dist/blitz.esm.js 102 B 0 B
packages/config/dist/blitzjs-config.cjs.dev.js 1.16 kB 0 B
packages/config/dist/blitzjs-config.cjs.js 146 B 0 B
packages/config/dist/blitzjs-config.cjs.prod.js 1.16 kB 0 B
packages/config/dist/blitzjs-config.esm.js 1.03 kB 0 B
packages/core/config/dist/blitzjs-core-config.cjs.dev.js 260 B 0 B
packages/core/config/dist/blitzjs-core-config.cjs.js 150 B 0 B
packages/core/config/dist/blitzjs-core-config.cjs.prod.js 260 B 0 B
packages/core/config/dist/blitzjs-core-config.esm.js 73 B 0 B
packages/core/dist/blitz-data-080e83b6.cjs.dev.js 1 kB 0 B
packages/core/dist/blitz-data-11f14b56.cjs.prod.js 1 kB 0 B
packages/core/dist/blitz-data-d1f53a00.esm.js 910 B 0 B
packages/core/dist/blitzjs-core.cjs.dev.js 8.55 kB 0 B
packages/core/dist/blitzjs-core.cjs.js 144 B 0 B
packages/core/dist/blitzjs-core.cjs.prod.js 8.27 kB 0 B
packages/core/dist/blitzjs-core.esm.js 8.25 kB 0 B
packages/core/dist/constants-016ca9ae.esm.js 2.34 kB 0 B
packages/core/dist/constants-7093bd41.cjs.dev.js 2.44 kB 0 B
packages/core/dist/constants-77910dbe.cjs.prod.js 2.44 kB 0 B
packages/core/dist/extends-1b905a27.esm.js 241 B 0 B
packages/core/dist/extends-93eedbb0.cjs.dev.js 250 B 0 B
packages/core/dist/extends-f26277ce.cjs.prod.js 250 B 0 B
packages/core/document/dist/blitzjs-core-document.cjs.dev.js 448 B 0 B
packages/core/document/dist/blitzjs-core-document.cjs.js 151 B 0 B
packages/core/document/dist/blitzjs-core-document.cjs.prod.js 450 B 0 B
packages/core/document/dist/blitzjs-core-document.esm.js 272 B 0 B
packages/core/dynamic/dist/blitzjs-core-dynamic.cjs.dev.js 263 B 0 B
packages/core/dynamic/dist/blitzjs-core-dynamic.cjs.js 151 B 0 B
packages/core/dynamic/dist/blitzjs-core-dynamic.cjs.prod.js 263 B 0 B
packages/core/dynamic/dist/blitzjs-core-dynamic.esm.js 73 B 0 B
packages/core/head/dist/blitzjs-core-head.cjs.dev.js 245 B 0 B
packages/core/head/dist/blitzjs-core-head.cjs.js 148 B 0 B
packages/core/head/dist/blitzjs-core-head.cjs.prod.js 245 B 0 B
packages/core/head/dist/blitzjs-core-head.esm.js 64 B 0 B
packages/core/image/dist/blitzjs-core-image.cjs.dev.js 249 B 0 B
packages/core/image/dist/blitzjs-core-image.cjs.js 149 B 0 B
packages/core/image/dist/blitzjs-core-image.cjs.prod.js 249 B 0 B
packages/core/image/dist/blitzjs-core-image.esm.js 65 B 0 B
packages/core/server/dist/blitzjs-core-server.cjs.js 148 B 0 B
packages/core/with-blitz/dist/blitzjs-core-with-blitz.cjs.dev.js 1.29 kB 0 B
packages/core/with-blitz/dist/blitzjs-core-with-blitz.cjs.js 151 B 0 B
packages/core/with-blitz/dist/blitzjs-core-with-blitz.cjs.prod.js 1.29 kB 0 B
packages/core/with-blitz/dist/blitzjs-core-with-blitz.esm.js 1.15 kB 0 B
packages/display/dist/blitzjs-display.cjs.dev.js 2 kB 0 B
packages/display/dist/blitzjs-display.cjs.js 147 B 0 B
packages/display/dist/blitzjs-display.cjs.prod.js 1.95 kB 0 B
packages/display/dist/blitzjs-display.esm.js 1.86 kB 0 B
packages/file-pipeline/dist/blitzjs-file-pipeline.cjs.dev.js 6.88 kB 0 B
packages/file-pipeline/dist/blitzjs-file-pipeline.cjs.js 150 B 0 B
packages/file-pipeline/dist/blitzjs-file-pipeline.cjs.prod.js 6.88 kB 0 B
packages/file-pipeline/dist/blitzjs-file-pipeline.esm.js 6.61 kB 0 B
packages/generator/dist/blitzjs-generator.cjs.dev.js 13.7 kB 0 B
packages/generator/dist/blitzjs-generator.cjs.js 148 B 0 B
packages/generator/dist/blitzjs-generator.cjs.prod.js 13.7 kB 0 B
packages/generator/dist/blitzjs-generator.esm.js 13.3 kB 0 B
packages/generator/dist/templates/app/babel.config.js 78 B 0 B
packages/generator/dist/templates/app/blitz.config.js 310 B 0 B
packages/generator/dist/templates/app/jest.config.js 60 B 0 B
packages/installer/dist/blitzjs-installer.cjs.dev.js 6.91 kB 0 B
packages/installer/dist/blitzjs-installer.cjs.js 148 B 0 B
packages/installer/dist/blitzjs-installer.cjs.prod.js 6.91 kB 0 B
packages/installer/dist/blitzjs-installer.esm.js 6.72 kB 0 B
packages/repl/dist/blitzjs-repl.cjs.dev.js 1.75 kB 0 B
packages/repl/dist/blitzjs-repl.cjs.js 144 B 0 B
packages/repl/dist/blitzjs-repl.cjs.prod.js 1.75 kB 0 B
packages/repl/dist/blitzjs-repl.esm.js 1.6 kB 0 B
packages/server/dist/blitzjs-server.cjs.dev.js 12.6 kB 0 B
packages/server/dist/blitzjs-server.cjs.js 145 B 0 B
packages/server/dist/blitzjs-server.cjs.prod.js 12.6 kB 0 B
packages/server/dist/blitzjs-server.esm.js 12.4 kB 0 B

compressed-size-action

@flybayer flybayer changed the title Fixed duplicated Set-Cookie header Fix duplicated Set-Cookie header Mar 15, 2021
@flybayer flybayer merged commit 720ee60 into canary Mar 15, 2021
@flybayer flybayer deleted the 1837-duplicated-headers branch March 15, 2021 22:27
@itsdillon itsdillon changed the title Fix duplicated Set-Cookie header [legacy-framework] Fix duplicated Set-Cookie header Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set-Cookie appears to be called twice if there is no anonymous session present.
2 participants