Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[legacy-framework] Fix invoke return type #2044

Merged
merged 1 commit into from
Mar 3, 2021
Merged

Conversation

Skn0tt
Copy link
Member

@Skn0tt Skn0tt commented Mar 3, 2021

Closes: blitz-js/legacy-framework#515

What are the changes and their implications?

Fixes blitz-js/legacy-framework#515.

Checklist

  • Changes covered by tests (tests added if needed)
  • PR submitted to blitzjs.com for any user facing changes

@Skn0tt
Copy link
Member Author

Skn0tt commented Mar 3, 2021

I've tested with @Swapnull's https://github.com/Swapnull/invoke-any-error-blitz, and the error went away.

@flybayer should we add unit tests for this? Do we already have type tests in place?

@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2021

Size Change: 0 B

Total Size: 214 kB

ℹ️ View Unchanged
Filename Size Change
packages/babel-preset/dist/blitzjs-babel-preset.cjs.dev.js 815 B 0 B
packages/babel-preset/dist/blitzjs-babel-preset.cjs.js 150 B 0 B
packages/babel-preset/dist/blitzjs-babel-preset.cjs.prod.js 815 B 0 B
packages/babel-preset/dist/blitzjs-babel-preset.esm.js 752 B 0 B
packages/blitz/cli/dist/blitz-cli.cjs.dev.js 1.47 kB 0 B
packages/blitz/cli/dist/blitz-cli.cjs.js 142 B 0 B
packages/blitz/cli/dist/blitz-cli.cjs.prod.js 1.47 kB 0 B
packages/blitz/cli/dist/blitz-cli.esm.js 1.37 kB 0 B
packages/blitz/dist/blitz.cjs.dev.js 232 B 0 B
packages/blitz/dist/blitz.cjs.js 139 B 0 B
packages/blitz/dist/blitz.cjs.prod.js 232 B 0 B
packages/blitz/dist/blitz.esm.js 51 B 0 B
packages/config/dist/blitzjs-config.cjs.dev.js 1.01 kB 0 B
packages/config/dist/blitzjs-config.cjs.js 146 B 0 B
packages/config/dist/blitzjs-config.cjs.prod.js 1 kB 0 B
packages/config/dist/blitzjs-config.esm.js 878 B 0 B
packages/core/dist/blitzjs-core.cjs.dev.js 15.6 kB 0 B
packages/core/dist/blitzjs-core.cjs.js 144 B 0 B
packages/core/dist/blitzjs-core.cjs.prod.js 15.3 kB 0 B
packages/core/dist/blitzjs-core.esm.js 15 kB 0 B
packages/display/dist/blitzjs-display.cjs.dev.js 2 kB 0 B
packages/display/dist/blitzjs-display.cjs.js 147 B 0 B
packages/display/dist/blitzjs-display.cjs.prod.js 1.95 kB 0 B
packages/display/dist/blitzjs-display.esm.js 1.86 kB 0 B
packages/file-pipeline/dist/blitzjs-file-pipeline.cjs.dev.js 6.88 kB 0 B
packages/file-pipeline/dist/blitzjs-file-pipeline.cjs.js 150 B 0 B
packages/file-pipeline/dist/blitzjs-file-pipeline.cjs.prod.js 6.88 kB 0 B
packages/file-pipeline/dist/blitzjs-file-pipeline.esm.js 6.61 kB 0 B
packages/generator/dist/blitzjs-generator.cjs.dev.js 13.7 kB 0 B
packages/generator/dist/blitzjs-generator.cjs.js 148 B 0 B
packages/generator/dist/blitzjs-generator.cjs.prod.js 13.7 kB 0 B
packages/generator/dist/blitzjs-generator.esm.js 13.3 kB 0 B
packages/generator/dist/templates/app/babel.config.js 78 B 0 B
packages/generator/dist/templates/app/blitz.config.js 316 B 0 B
packages/generator/dist/templates/app/jest.config.js 60 B 0 B
packages/installer/dist/blitzjs-installer.cjs.dev.js 6.91 kB 0 B
packages/installer/dist/blitzjs-installer.cjs.js 148 B 0 B
packages/installer/dist/blitzjs-installer.cjs.prod.js 6.91 kB 0 B
packages/installer/dist/blitzjs-installer.esm.js 6.72 kB 0 B
packages/repl/dist/blitzjs-repl.cjs.dev.js 1.75 kB 0 B
packages/repl/dist/blitzjs-repl.cjs.js 144 B 0 B
packages/repl/dist/blitzjs-repl.cjs.prod.js 1.75 kB 0 B
packages/repl/dist/blitzjs-repl.esm.js 1.6 kB 0 B
packages/server/dist/blitzjs-server.cjs.dev.js 21.2 kB 0 B
packages/server/dist/blitzjs-server.cjs.js 145 B 0 B
packages/server/dist/blitzjs-server.cjs.prod.js 21.2 kB 0 B
packages/server/dist/blitzjs-server.esm.js 21 kB 0 B

compressed-size-action

@flybayer
Copy link
Member

flybayer commented Mar 3, 2021

Thanks! We don't currently have many type tests. I want to set up an integration testing structure like the next.js repo where we can add tests for things like this (and stop using examples as tests :D)

@flybayer flybayer changed the title #2016: invoke should correctly infer types Fix invoke return type Mar 3, 2021
@flybayer flybayer merged commit e41401c into canary Mar 3, 2021
@flybayer flybayer deleted the 2016-invoke-return-type branch March 3, 2021 22:12
@itsdillon itsdillon changed the title Fix invoke return type [legacy-framework] Fix invoke return type Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

invoke returning Promise<any> rather than query return type
2 participants