[legacy-framework] Fix Cannot read property 'toString' of null for blitz new
#2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Woohoo, thank you! @all-contributors add @roesh for code |
|
I've put up a pull request to add @roesh! 🎉 |
flybayer
changed the title
blitz new
itsdillon
changed the title
blitz newblitz new
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: blitz-js/legacy-framework#523
What are the changes and their implications?
Adding checks to make sure the checkYarn buffer and its stdout are not null or undefined before calling .toString() on them. This ensures that the useYarn variable which determines whether we use yarn or npm to upgrade blitz is properly set, and the rest of the upgrade happens without an error being thrown if the user doesn't have yarn installed
Checklist
I was unable to test this because the issue was only occurring when I didn't have yarn installed, but I needed yarn installed and needed to be running the yarn dev command in order to run the commands using the local blitz version I was working on in the example directory