Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[legacy-framework] Beautify query/mutation logging and Refactor logger #199

Merged
merged 7 commits into from
Apr 24, 2020

Conversation

merelinguist
Copy link

@merelinguist merelinguist commented Apr 23, 2020

Pull Request Type

  • Feature
  • Bug fix
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Tests related changes
  • Other (please describe): Dependency updates

Checklist

  • Tests added for changes (or N/A)
  • Any added terminal logging uses packages/server/src/log.ts (or N/A)
  • Code Coverage stayed the same or increased

What's the reason for the change? ❓

Starts blitz-js/legacy-framework#896

What are the changes and their implications? ⚙️

Does this introduce a breaking change? ⚠️

  • Yes
  • No

Other information

carbon (1)

@flybayer
Copy link
Member

Cool!

  • Remove the log for the HEAD request
  • Remove "POST" from the log (it's always POST)
  • Change "fetched" to "returned"
  • And sorry, I caused you conflicts with canary branch!

This is a good start for the alpha, but it won't close blitz-js/legacy-framework#896 yet because of all the other requirements in it. We can tackle those later if you want

@merelinguist
Copy link
Author

@flybayer All done. Sorry, hadn’t looked at the issue in a while! I’ll do a later pr for more rpc stuff if you’re happy enough with how this looks for alpha.

@merelinguist merelinguist requested a review from ryardley as a code owner April 24, 2020 05:26
Copy link
Member

@flybayer flybayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was having warnings from the server package, so I moved the server rpc handler into the server package to ensure we don't have client/server bundle issues. Core is always bundled into client, but server never is.

Also improved the logging a bit more :)

@flybayer flybayer changed the title Refactor logger and beautify rpc logging Beautify query/mutation logging and Refactor logger Apr 24, 2020
@flybayer flybayer merged commit 2dfa865 into canary Apr 24, 2020
@flybayer flybayer deleted the rpc-logging branch April 24, 2020 05:36
@itsdillon itsdillon changed the title Beautify query/mutation logging and Refactor logger [legacy-framework] Beautify query/mutation logging and Refactor logger Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature-change New feature or request scope/core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants