Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[legacy-framework] Fix possible race condition during blitz new #198

Merged
merged 5 commits into from
Apr 24, 2020

Conversation

Zeko369
Copy link
Collaborator

@Zeko369 Zeko369 commented Apr 23, 2020

Pull Request Type

  • Feature
  • Bug fix
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Tests related changes
  • Other (please describe): Dependency updates

Checklist

  • Tests added for changes (or N/A)
  • Any added terminal logging uses packages/server/src/log.ts (or N/A)
  • Code Coverage stayed the same or increased

What's the reason for the change? ❓

Closes: blitz-js/legacy-framework#887

What are the changes and their implications? ⚙️

Does this introduce a breaking change? ⚠️

  • Yes
  • No

Other information

@Zeko369 Zeko369 requested a review from flybayer as a code owner April 23, 2020 14:43
@flybayer
Copy link
Member

@all-contributors add @Zeko369 for code

@allcontributors
Copy link

@flybayer

I've put up a pull request to add @Zeko369! 🎉

@flybayer
Copy link
Member

Also fix the new conflict with canary

Copy link
Member

@flybayer flybayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@flybayer flybayer changed the title Refactor dependecy upgrader to mitigate the race condition Fix possible race condition during blitz new Apr 24, 2020
@flybayer flybayer merged commit 7097150 into blitz-js:canary Apr 24, 2020
@itsdillon itsdillon changed the title Fix possible race condition during blitz new [legacy-framework] Fix possible race condition during blitz new Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need to refactor blitz new replaceDependencies: possibility for race condition failure
2 participants