-
-
Notifications
You must be signed in to change notification settings - Fork 798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[legacy-framework] remove typescript bits from package.json generated for js projects #1402
Conversation
@bcye thanks so much! This solution would definitely work, but it would be better to only have a single package.json that has a few conditional changes based on whether it is JS or TS. Because with two package.json's, it will be easy for them to get out of sync. @aem does our custom template engine support conditional checks in json files? |
Bump @aem |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@beerose looks good, but we should remove @types
packages from js package.json. Once that's changed, you are good to merge without another check from me.
Also I remembered that we run tsc
inside the husky pre-push hook. We need to remove that for JS version. Can do that as a separate PR though.
Yep! Will work on that in a separate pr |
package.json
generated for JS projects contains bits for TS projects
Added @bcye contributions for code |
@bcye so sorry for the long delay on this!!! I was thinking we needed to make changes in our codegen process, but ultimately decided to just go with your original approach for now, even though there is some duplication we have to worry about. |
Closes: blitz-js/legacy-framework#951
What are the changes and their implications?
Checklist