fix: properly add authError query param to redirect url (#4027)

blitz-js · Jan 2, 2023 · 82e8b64 · 82e8b64
1 parent e9dfbcf
commit 82e8b64
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/.changeset/dull-rings-arrive.md b/.changeset/dull-rings-arrive.md
@@ -0,0 +1,5 @@
+---
+"@blitzjs/auth": patch
+---
+
+Fixes adding authError query param in Passport adapter.
diff --git a/packages/blitz-auth/src/server/passport-adapter.ts b/packages/blitz-auth/src/server/passport-adapter.ts
@@ -172,8 +172,10 @@ export function passportAuth(config: BlitzPassportConfig): ApiHandler {
               if (error) {
                 console.error(`Login via ${strategyName} was unsuccessful.`)
                 console.error(error)
+
+                const authErrorQueryStringKey = redirectUrl.includes("?") ? "&authError=" : "?authError=";
                 redirectUrl +=
-                  "?authError=" + encodeURIComponent(truncateString(error.toString(), 100))
+                  authErrorQueryStringKey + encodeURIComponent(truncateString(error.toString(), 100))
                 res.setHeader("Location", redirectUrl)
                 res.statusCode = 302
                 res.end()