fix blitz generate --dry-run flag not being respected (#2858)

(patch)
blitz-js · Oct 19, 2021 · 6f37571 · 6f37571
1 parent 4e6f829
commit 6f37571
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/packages/cli/test/commands/new.test.ts b/packages/cli/test/commands/new.test.ts
@@ -202,6 +202,15 @@ describe("`new` command", () => {
       })
     })
 
+    testIfNotWindows("accepts --dry-run flag and doesn't create files", async () => {
+      const newAppDir = fs.mkdtempSync(path.join(tempDir, "full-install-"))
+      await whileStayingInCWD(() => New.run([newAppDir, "--skip-upgrade", "--dry-run"]))
+
+      expect(fs.existsSync(newAppDir)).toBe(true)
+      expect(fs.existsSync(path.join(newAppDir, "package.json"))).toBe(false)
+      expect(stdout.output).toContain("Would create")
+    })
+
     it("fetches latest version from template", async () => {
       const expectedVersion = "3.0.0"
       const templatePackage = {name: "eslint-plugin-react-hooks", version: "3.x"}

diff --git a/packages/generator/src/conflict-checker.ts b/packages/generator/src/conflict-checker.ts
@@ -24,6 +24,7 @@ export class ConflictChecker extends Transform {
     super({
       objectMode: true,
     })
+    this.options = options
   }
 
   _transform(file: File, _encoding: string, cb: TransformCallback): void {
-Original file line number
+Diff line change
@@ Expand Up / @@ -24,6 +24,7 @@ export class ConflictChecker extends Transform { @@
         super({
           objectMode: true,
         })
+        this.options = options
       }
       _transform(file: File, _encoding: string, cb: TransformCallback): void {
@@ Expand Down @@