Remove useEffect from reset password templates (#4051)

Co-authored-by: Siddharth Suresh <[email protected]> Co-authored-by: Brandon Bayer <[email protected]>
blitz-js · Feb 9, 2023 · 6ec020c · 6ec020c
1 parent a3d8b28
commit 6ec020c
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 11 deletions.
diff --git a/.changeset/perfect-baboons-relate.md b/.changeset/perfect-baboons-relate.md
@@ -0,0 +1,5 @@
+---
+"@blitzjs/generator": patch
+---
+
+Remove useEffect from reset password templates.
diff --git a/apps/toolkit-app/src/pages/auth/reset-password.tsx b/apps/toolkit-app/src/pages/auth/reset-password.tsx
@@ -10,14 +10,10 @@ import { useMutation } from "@blitzjs/rpc"
 import Link from "next/link"
 
 const ResetPasswordPage: BlitzPage = () => {
-  const [token, setToken] = useState("")
   const router = useRouter()
+  const token = router.query.token?.toString()
   const [resetPasswordMutation, { isSuccess }] = useMutation(resetPassword)
 
-  useEffect(() => {
-    setToken(router.query.token as string)
-  }, [router.isReady])
-
   return (
     <div>
       <h1>Set a New Password</h1>

diff --git a/packages/generator/templates/app/src/pages/auth/reset-password.tsx b/packages/generator/templates/app/src/pages/auth/reset-password.tsx
@@ -10,14 +10,10 @@ import { useMutation } from "@blitzjs/rpc"
 import Link from "next/link"
 
 const ResetPasswordPage: BlitzPage = () => {
-  const [token, setToken] = useState("")
   const router = useRouter()
+  const token = router.query.token?.toString()
   const [resetPasswordMutation, { isSuccess }] = useMutation(resetPassword)
 
-  useEffect(() => {
-    setToken(router.query.token as string)
-  }, [router.isReady])
-
   return (
     <div>
       <h1>Set a New Password</h1>
@@ -40,7 +36,7 @@ const ResetPasswordPage: BlitzPage = () => {
           }}
           onSubmit={async (values) => {
             try {
-              await resetPasswordMutation({...values, token})
+              await resetPasswordMutation({ ...values, token })
             } catch (error: any) {
               if (error.name === "ResetPasswordError") {
                 return {