Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Color names #48

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

angusm
Copy link
Member

@angusm angusm commented Nov 29, 2020

This might be a call on weight, whether we want to have this functionality for users or insist on HEX/RGB values instead.

@uxder
Copy link
Member

uxder commented Nov 29, 2020

Thanks Angus for adding this.

@jeremydw @stevenle Do you have an opinion on this? I personally never use color names so am thinking we perhaps omit it but we can include it if others find useful.

@stevenle
Copy link
Member

i personally would prefer to keep the library small (in size and in memory usage) and the map looks fairly big for functionality that could be moved to where it's being called.

@jeremydw
Copy link
Member

jeremydw commented Nov 30, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants