Skip unsavable #321
Merged
Skip unsavable #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@blink1073 Does that errors due to my changes? I didn't see that errors running on my local after my changes. Please review. Thanks. |
|
Tests failed here: tests/test_misc.py::TestMisc::test_plot FAILED [ 16%]
tests/test_usage.py::TestUsage::test_extract_figures FAILED [ 71%]
tests/test_usage.py::TestUsage::test_keyword_arguments FAILED [ 74%]
tests/ipython/test_octavemagic.py::OctaveMagicTest::test_octave_plot FAILED [ 98%]
tests/ipython/test_octavemagic.py::OctaveMagicTest::test_octave_roundtrip FAILED [ 99%]Tests failed on master https://github.com/yasirroni/oct2py/actions/runs/9385250320 in yasirroni@ef97de8 tests/test_misc.py::TestMisc::test_plot FAILED [ 16%]
tests/test_usage.py::TestUsage::test_extract_figures FAILED [ 71%]
tests/test_usage.py::TestUsage::test_keyword_arguments FAILED [ 74%]
tests/ipython/test_octavemagic.py::OctaveMagicTest::test_octave_plot FAILED [ 98%]
tests/ipython/test_octavemagic.py::OctaveMagicTest::test_octave_roundtrip FAILED [ 99%] |
|
Yes, I'm not sure why the plotting backend started failing in CI, I haven't had a chance to look into it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
save('-v6', '-mat-binary', output_file, 'result', 'err');fail in_pyeval.m, recursive check data type. Remove cell or struct value if not from{'double', 'char', 'logical', 'sparse'}.If you have other data types list or a better way to support if a data
savable, please give feed back.