Updating Existing Interfaces with DiskStatsReporter #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thejas-bhat
requested review from
abhinavdangeti,
metonymic-smokey and
moshaad7
This was referenced Oct 18, 2022
Thejas-bhat
changed the title
abhinavdangeti
approved these changes
Oct 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a regression observed with respect to query throughput and latency as part of the IO stats computation which was introduced in bleve v2.3.4. The changes involved in this PR mainly includes updating the existing interfaces to avoid costly interface assertions in the hot code paths.
The bleve issue: blevesearch/bleve#1731
The Bleve PR solving the issue: blevesearch/bleve#1738