Skip to content

Commit

Permalink
Append ROCm flag to compile definitions for Python instead of overwri…
Browse files Browse the repository at this point in the history
…ting (facebookresearch#3742)

Summary:
Pull Request resolved: facebookresearch#3742

Before this change, the CMake line was setting (instead of appending to) compile definitions for Python code which replace the GPU wrappers flag and resulting in Python library compiling with no GPU code which failed ROCm tests.

Reviewed By: junjieqi

Differential Revision: D61007640

fbshipit-source-id: 174aeb0a4abe0607629ddf57c882d19ea2d6c6bf
  • Loading branch information
ramilbakhshyiev authored and facebook-github-bot committed Aug 9, 2024
1 parent 13371c7 commit 11c15af
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion faiss/python/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ macro(configure_swigfaiss source)
COMPILE_DEFINITIONS GPU_WRAPPER
)
if (FAISS_ENABLE_ROCM)
set_source_files_properties(${source} PROPERTIES
set_property(SOURCE ${source} APPEND PROPERTY
COMPILE_DEFINITIONS FAISS_ENABLE_ROCM
)
endif()
Expand Down

0 comments on commit 11c15af

Please sign in to comment.