MB-61009: Raise max supported dimensionality of vectors to 4096 #2015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhinavdangeti
requested review from
Thejas-bhat,
metonymic-smokey,
CascadingRadium,
Likith101 and
moshaad7
+ Allow calling application to change min/max. + Will require downstream changes to disallow any setting greater than 2048 in the event of a mixed version cluster.
Likith101
approved these changes
Apr 25, 2024
CascadingRadium
approved these changes
Apr 25, 2024
ns-codereview
pushed a commit
to couchbase/cbft
that referenced
this pull request
Apr 25, 2024
+ Cluster version tracking for features:
- xattrs
- vector_base64
- dims:4096
+ This change separates out feature strings for xattrs and vector_base64
because xattrs is not restricted to vectors alone.
+ vector_base64 is combined with dims:4096 which are meant to go out
together in v2 (7.6.2).
+ Also requires: blevesearch/bleve#2015
Change-Id: I44daa225b5c397e9f8cae26ce3fcb36cab9b26d6
Reviewed-on: https://review.couchbase.org/c/cbft/+/208927
Well-Formed: Build Bot <[email protected]>
Well-Formed: Restriction Checker
Reviewed-by: Likith B <[email protected]>
Tested-by: Abhi Dangeti <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
than 2048 in the event of a mixed version cluster.