Support overrideable json Marshaler/Unmarshaler #1880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhinavdangeti
requested review from
Thejas-bhat,
metonymic-smokey,
CascadingRadium,
Likith101 and
moshaad7
Thejas-bhat
approved these changes
Sep 11, 2023
moshaad7
reviewed
Sep 11, 2023
| } |
moshaad7
reviewed
Sep 11, 2023
| @@ -135,22 +135,22 @@ func (udc *UpsideDownCouch) loadSchema(kvreader store.KVReader) (err error) { | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
This file have unrelated changes coming from go fmt,
we have another PR raised for "go fmt" changes (#1874) based off of master.
We can rebase this PR on top of that.
There was a problem hiding this comment.
This is just a go fmt and given that it'll be backported as is - let's leave this as is for now and rebase #1874 instead.
ns-codereview
pushed a commit
to couchbase/cbft
that referenced
this pull request
Sep 11, 2023
+ Refactoring all direct calls to the standard library's
marshal/unmarshal with json-iterator's CustomJSONImpl, which
is proven to be a lot faster and is already used in certain
places.
+ Override bleve's MarshalJSON/UnmarshalJSON
(blevesearch/bleve#1880)
+ Override cbgt's MarshalJSON/UnmarshalJSON
(https://review.couchbase.org/c/cbgt/+/196883)
Change-Id: Ia31377cf5680685e19b8cc1b0ab27a9e51ce7112
Reviewed-on: https://review.couchbase.org/c/cbft/+/196886
Reviewed-by: Aditi Ahuja <[email protected]>
Tested-by: Abhi Dangeti <[email protected]>
CascadingRadium
pushed a commit
that referenced
this pull request
Sep 13, 2023
Thejas-bhat
pushed a commit
that referenced
this pull request
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.