MB-54131: Geoshape query decode optimization #1864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added a buffer pool to be shared by all documents
Likith101
requested review from
abhinavdangeti,
Thejas-bhat,
metonymic-smokey,
CascadingRadium and
moshaad7
Thejas-bhat
reviewed
Aug 22, 2023
moshaad7
reviewed
Aug 23, 2023
moshaad7
reviewed
Aug 23, 2023
- Removed initialization of buffers in the pool - Modified code to fit GeoBufferPool
- Added buffer pool to context - Added relavent key and callback functions in util.go
moshaad7
reviewed
Aug 29, 2023
moshaad7
reviewed
Aug 29, 2023
- Changed bufPool initialization to be used only when query has geoshape component
abhinavdangeti
requested changes
Aug 30, 2023
- Changed constant names to better reflect their purpose
- Handled an edge case where searcher is called with nil context
go.sum
Outdated
| @@ -92,8 +92,10 @@ golang.org/x/sys v0.0.0-20220520151302-bc2c85ada10a/go.mod h1:oPkhp1MJrh7nUepCBc | |||
| golang.org/x/sys v0.5.0 h1:MUK/U/4lj1t1oPg0HfuXDN/Z1wv31ZJ/YcPiGccS4DU= | |||
| golang.org/x/sys v0.5.0/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg= | |||
| golang.org/x/text v0.3.0/go.mod h1:NqM8EUOU14njkJ3fqMW+pc6Ldnwhi/IjpwHt7yyuwOQ= | |||
| golang.org/x/text v0.3.2/go.mod h1:bEr9sfX3Q8Zfm5fL9x+3itogRgK3+ptLWKqgva+5dAk= | |||
There was a problem hiding this comment.
Line 95 & 98 below seem unrelated.
abhinavdangeti
approved these changes
Aug 31, 2023
abhinavdangeti
pushed a commit
that referenced
this pull request
Aug 31, 2023
- Added a buffer pool to be shared by all documents - Removed initialization of buffers in the pool - Modified code to fit GeoBufferPool - Added buffer pool to context - Added relavent key and callback functions in util.go - Changed bufPool initialization to be used only when query has geoshape component - Changed constant names to better reflect their purpose - Handled an edge case where searcher is called with nil context
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs