Add support of Polish language #1825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks you for this contribution @nickspring. |
abhinavdangeti
requested review from
abhinavdangeti,
Thejas-bhat,
metonymic-smokey and
moshaad7
abhinavdangeti
requested changes
Jul 12, 2023
analysis/lang/pl/stemmer_pl.go
Outdated
| func NewPolishStemmerFilter() *PolishStemmerFilter { | ||
| trie, err := stempel.LoadTrie() | ||
| if err != nil { | ||
| log.Fatal(err) |
There was a problem hiding this comment.
Let's return an error here as opposed to log.Fatal.
There was a problem hiding this comment.
done, thank you for review
abhinavdangeti
approved these changes
Jul 24, 2023
|
@nickspring One last request (probably) here - would you rebase your change over master to resolve the unresolved conflicts. We can target this for v2.3.10 then. |
|
done |
CascadingRadium
pushed a commit
that referenced
this pull request
Aug 31, 2023
* Add Polish language support * Add Polish language support: embed stempel lib & tbl file * Add Polish language support: embed stempel lib & tbl file * Pull request fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've embedded http://github.com/blevesearch/stempel to bleavesearch because I needed changes here too (to embed *.tbl file in build I need load tier from bytes array, not only by filename). Unfortunately it's complicated to track 2 pull requests as I need it in my project right now.