Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rubocop requirement from 1.64.1 to 1.65.1 #25

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

dependabot[bot]
Copy link

@dependabot dependabot bot commented on behalf of github Aug 1, 2024

Updates the requirements on rubocop to permit the latest version.

Release notes

Sourced from rubocop's releases.

RuboCop 1.65.1

New features

  • #13068: Add config validation to Naming/PredicateName to check that all ForbiddenPrefixes are being checked. (@​maxjacobson)

Bug fixes

  • #13051: Fix an error for Lint/FloatComparison when comparing with rational literal. (@​koic)
  • #13065: Fix an error for Lint/UselessAssignment when same name variables are assigned using chained assignment. (@​koic)
  • #13062: Fix an error for Style/InvertibleUnlessCondition when using empty parenthesis as condition. (@​earlopain)
  • #11438: Explicitly load fileutils before calculating before_us. (@​r7kamura)
  • #13044: Fix false negatives for Lint/ImplicitStringConcatenation when using adjacent string interpolation literals on the same line. (@​koic)
  • #13083: Fix a false positive for Style/GlobalStdStream when using namespaced constants like Foo::STDOUT. (@​earlopain)
  • #13081: Fix a false positive for Style/ZeroLengthPredicate when using safe navigation and non-zero comparison. (@​fatkodima)
  • #13041: Fix false positives for Lint/UselessAssignment when pattern match variable is assigned and used in a block. (@​koic)
  • #13076: Fix an incorrect autocorrect for Naming/RescuedExceptionsVariableName when using hash value omission. (@​koic)
Changelog

Sourced from rubocop's changelog.

1.65.1 (2024-08-01)

New features

  • #13068: Add config validation to Naming/PredicateName to check that all ForbiddenPrefixes are being checked. ([@​maxjacobson][])

Bug fixes

  • #13051: Fix an error for Lint/FloatComparison when comparing with rational literal. ([@​koic][])
  • #13065: Fix an error for Lint/UselessAssignment when same name variables are assigned using chained assignment. ([@​koic][])
  • #13062: Fix an error for Style/InvertibleUnlessCondition when using empty parenthesis as condition. ([@​earlopain][])
  • #11438: Explicitly load fileutils before calculating before_us. ([@​r7kamura][])
  • #13044: Fix false negatives for Lint/ImplicitStringConcatenation when using adjacent string interpolation literals on the same line. ([@​koic][])
  • #13083: Fix a false positive for Style/GlobalStdStream when using namespaced constants like Foo::STDOUT. ([@​earlopain][])
  • #13081: Fix a false positive for Style/ZeroLengthPredicate when using safe navigation and non-zero comparison. ([@​fatkodima][])
  • #13041: Fix false positives for Lint/UselessAssignment when pattern match variable is assigned and used in a block. ([@​koic][])
  • #13076: Fix an incorrect autocorrect for Naming/RescuedExceptionsVariableName when using hash value omission. ([@​koic][])

1.65.0 (2024-07-10)

New features

Bug fixes

  • #12954: Fix a false negative for Style/ArgumentsForwarding when arguments forwarding in yield. ([@​koic][])
  • #13033: Fix a false positive for Layout/SpaceAroundOperators when using multiple spaces between an operator and a tailing comment. ([@​koic][])
  • #12885: Fix a false positive for Lint/ToEnumArguments when enumerator is created for another method. ([@​koic][])
  • #13018: Fix a false positive for Style/MethodCallWithArgsParentheses when EnforcedStyle: omit_parentheses is set and parenthesized method call is used before constant resolution. ([@​koic][])
  • #12986: Fix a false positive for Style/RedundantBegin when endless method definition with rescue. ([@​koic][])
  • #12985: Fix an error for Style/RedundantRegexpCharacterClass when using regexp_parser gem 2.3.1 or older. ([@​koic][])
  • #13010: Fix an error for Style/SuperArguments when the hash argument is or-assigned. ([@​koic][])
  • #13023: Fix an error for Style/SymbolProc when using lambda -> with one argument and multiline do...end block. ([@​koic][])
  • #12989: Fix an error for the inherit_gem config when the Gemfile contains an uninstalled git gem. ([@​earlopain][])
  • #12975: Fix an error for the inherit_gem config when running RuboCop without bundler and no Gemfile exists. ([@​earlopain][])
  • #12997: Fix an error for Lint/UnmodifiedReduceAccumulator when the block is empty. ([@​earlopain][])
  • #12979: Fix false negatives for Lint/Void when void expression with guard clause is not on last line. ([@​koic][])
  • #12716: Fix false negatives for Lint/Void when using parenthesized void operators. ([@​koic][])
  • #12471: Fix false negatives for Style/ZeroLengthPredicate when using safe navigation operator. ([@​koic][])
  • #12960: Fix false positives for Lint/NestedMethodDefinition when definition of method on variable. ([@​koic][])
  • #13012: Fix false positives for Style/HashExcept when using reject and calling include? method with bang. ([@​koic][])
  • #12983: Fix false positives for Style/SendWithLiteralMethodName using send with writer method name. ([@​koic][])
  • #12957: Fix false positives for Style/SuperArguments when calling super in a block. ([@​koic][])

Changes

  • #12970: Add CountModifierForms option to Metrics/BlockNesting and set it to false by default. ([@​koic][])
  • #13032: Display warning messages for deprecated APIs. ([@​koic][])
  • #13031: Enable YJIT by default in server mode. ([@​koic][])

... (truncated)

Commits
  • b073d7a Cut 1.65.1
  • 8c4c144 Update Changelog
  • 19b3d9d Merge pull request #13083 from Earlopain/false-positive-global-std-stream
  • 761b917 Fix false positive for Style/GlobalStdStream for namespaced constants
  • 58eeb7a Clarify docs in Naming/PredicateName
  • 2443641 Add a validate_config for Naming/PredicateName
  • 68bd9da Merge pull request #13079 from koic/fix_incorrect_autocorrect_for_naming_resc...
  • 748a568 Merge pull request #13081 from fatkodima/zero_length_predicate-false-positive
  • 70d8e88 Fix a false positive for Style/ZeroLengthPredicate when using safe navigati...
  • ea309c2 [Fix #13076] Fix an incorrect autocorrect for `Naming/RescuedExceptionsVariab...
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Updates the requirements on [rubocop](https://github.com/rubocop/rubocop) to permit the latest version.
- [Release notes](https://github.com/rubocop/rubocop/releases)
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md)
- [Commits](rubocop/rubocop@v1.64.1...v1.65.1)

---
updated-dependencies:
- dependency-name: rubocop
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added the 🏠 Housekeeping Non-user facing cleanup and maintenance label Aug 1, 2024
Copy link

coderabbitai bot commented Aug 1, 2024

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Note

Summarized by CodeRabbit Free

Your organization has reached its limit of developer seats under the Pro Plan. For new users, CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please add seats to your subscription by visiting https://app.coderabbit.ai/login.

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@kodiakhq kodiakhq bot merged commit b0b2f42 into main Aug 1, 2024
6 checks passed
@kodiakhq kodiakhq bot deleted the dependabot/bundler/rubocop-1.65.1 branch August 1, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏠 Housekeeping Non-user facing cleanup and maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants