Change spiffs to spiffsb to enable compile on Windows with VSCode and PlatformIO #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I came to conclution that Windows doesn't see difference between
#include "spiffs.h" and
#include "SPIFFS.h"
Therefore I propose to rename spiffs.h to spiffsb.h (b stands to Bleskomat).
As I'm noob I could not figure out how to keep -D FIRMWARE_COMMIT_HASH working. Therefore rude workaround in .ini
[firmware]
build_flags =
'-D FIRMWARE_NAME="Bleskomat DIY"'
'-D FIRMWARE_VERSION="v1.3.0"'
'-D FIRMWARE_COMMIT_HASH="win"'
; !echo "'-D FIRMWARE_COMMIT_HASH="$(git rev-parse HEAD)"'"
Would there be some way to have if clause in .ini depending of build platform to run "git" correctly on both linux and Windows with same .ini?
I was also streamlined #include clauses """ and "<" with same amount CRLF's on each.
Pleased to hear back.
Bear with me - this is my 1st c(pp) code change/creation proposal since 2001.