Tweak numbers related to retries, and message delivery guarantee #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This improves message delivery guarantees. The producer already has `batch.num.messages` set to 10.000, so it won't wait for acks on each message. If more performance is needed, at the cost of reliability, this can be tweaked using `KafkaRequireLeaderAck`.
JeanMertz
force-pushed
the
retry-config
branch
from
28eecde to
c5fc25a
Compare
|
Hello @JeanMertz, Hubbit here, Your Friendly Blendle Bot. I've marked this Pull Request as Here are some actions you can take to recover from this enormous stigma I just
Together we can improve our code quality and development flow. Happy Hackin'! |
Defaults to 15 seconds, to give the broker time to fix itself when an error is returned.
JeanMertz
force-pushed
the
retry-config
branch
from
c5fc25a to
a157657
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've seen situations where our cluster is returning some errors, and doesn't recover immediately, but will after a few seconds. By default, the retry logic retries after 100ms, which is too short for the cluster to recover.
With this change:
All of these values can be configured, but the default favours stability and correctness, over speed. In general though, I don't hink these changes will cause a big change in performance, because the producer already batches messages (10.000 by default) before delivering them to the brokers.