Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update requirements for Julia 1.0 and use compatible dependencies #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cynddl
Copy link

@cynddl cynddl commented Feb 4, 2020

@blegat Please check and let me know if everything is ok? The requirements could be cleaned a bit (StructDualDynProg is on master, QHull not needed, JuMP and StructJuMP only for tests, etc.).

I tried to remove MathProgBase as a requirement (was only needed in the notebook).
One test is now broken, not sure why but this seems to be an issue with Polyhedra.jl.

@cynddl
Copy link
Author

cynddl commented Feb 7, 2020

@blegat Any clue why Polyhedra._hinh is breaking the tests now? The testcase for !(zhangyeungineq in G) yields:

MethodError: no method matching zero(::MathOptInterface.VariableIndex)

Edit: asked on MOI directly: jump-dev/MathOptInterface.jl#1016

@blegat
Copy link
Owner

blegat commented Feb 9, 2020

The new version for Polyhedra should fix it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants