Add file drag over event emitter on enter and leave #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @AdrianPasalega, thank you for your PR. That looks alright, but nobody will know about usage of this. Can you please also add this to the README with the example and I will accept it? Thanks. |
|
Hi @jkuri , yes, you are right :), I add an example, let me know if it is ok. |
jkuri
reviewed
Sep 20, 2016
| <style> | ||
| .file-over { border: dotted 3px red; } /* Default class applied to drop zones on over */ | ||
| </style> | ||
| <div ng2FileDrop |
There was a problem hiding this comment.
typo. directive is named ngFileDrop not ng2FileDrop so this example would not work :) please fix.
|
Thanks! Merged and published new version to npm. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an event emitter to be able to modify drop zone css when moving the file over:
(fileOver)="fileOverDropZone($event)"