Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix duplicate file in queue #477

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix duplicate file in queue #477

wants to merge 1 commit into from

Conversation

mathieu-morchipont
Copy link

When I drop two files then I drop two others files when the first queue not started, the plugin upload two files first then four files because the files in the first queue are status UploadStatus.Queue

@CLAassistant
Copy link

CLAassistant commented Nov 9, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@mathieu-morchipont mathieu-morchipont force-pushed the fix/duplicate_file_in_queue branch from eac792c to 1e8d758 Compare November 23, 2018 14:05
Kangarused
Kangarused approved these changes Dec 10, 2019
View reviewed changes
Copy link

@Kangarused Kangarused left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've also encountered this issue, this does fix the problem and I don't see any potential bugs that could result unless the subs array is set to null at some point in a future commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kangarused Kangarused Kangarused approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mathieu-morchipont @CLAassistant @Kangarused