Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows setting of false boolean options #17

Merged
merged 1 commit into from
Mar 14, 2016
Merged

Conversation

zatomik
Copy link
Contributor

@zatomik zatomik commented Mar 14, 2016

For eg the default autoUpload: boolean = true;

then adding option in component to false

  options: Object = {
    url: 'http://localhost:10050/upload',
    autoUpload: false
  };

In the service will always return the default again (true) so replacing:

this.autoUpload = options && options.autoUpload || this.autoUpload;

with

this.autoUpload = options.autoUpload != null ? options.autoUpload : this.autoUpload;

@jkuri
Copy link
Contributor

jkuri commented Mar 14, 2016

Hi @zatomik, thanks for the fix!

jkuri added a commit that referenced this pull request Mar 14, 2016
Allows setting of false boolean options
@jkuri jkuri merged commit 59b6b41 into bleenco:master Mar 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants