Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular 2.2 AoT compiler fixes. create NgModule #129

Merged
merged 5 commits into from
Nov 19, 2016

Conversation

karlhiramoto
Copy link
Contributor

I upgraded Angular 2.2 and started to use the AoT compiler and found some issues

Notes:

dist/tmp/node_modules/ng2-uploader/src/directives/ng-file-drop.ngfactory.ts(64,35): error TS2346: Supplied parameters do not match any signature of call target.
dist/tmp/node_modules/ng2-uploader/src/directives/ng-file-drop.ngfactory.ts(68,35): error TS2346: Supplied parameters do not match any signature of call target.
Error: Cannot determine the module for class NgFileDropDirective in node_modules/ng2-uploader/src/directives/ng-file-drop.ts!
    at analyzeAndValidateNgModules (node_modules/@angular/compiler/bundles/compiler.umd.js:12707:17)
    at OfflineCompiler.compileModules (node_modules/@angular/compiler/bundles/compiler.umd.js:12775:20)
    at CodeGenerator.codegen (/Users/chuckj/src/angular/modules/@angular/compiler-cli/src/codegen.ts:71:26)
    at codegen (tools/tasks/seed/compile.ahead.prod.ts:13:69)
    at Object.main (/storage/karl/Work/xsact/tools/@angular/tsc-wrapped/src/main.ts:44:12)
    at module.exports (tools/tasks/seed/compile.ahead.prod.ts:39:3)
    at AnonTask.run (tools/utils/seed/tasks_tools.ts:31:18)
    at Gulp.<anonymous> (tools/utils/seed/tasks_tools.ts:60:27)
    at module.exports (node_modules/orchestrator/lib/runTask.js:34:7)
    at Gulp.Orchestrator._runTask (node_modules/orchestrator/index.js:273:3)
Compilation failed

maxi and others added 5 commits November 18, 2016 16:32
```
dist/tmp/node_modules/ng2-uploader/src/directives/ng-file-drop.ngfactory.ts(64,35): error TS2346: Supplied parameters do not match any signature of call target.
dist/tmp/node_modules/ng2-uploader/src/directives/ng-file-drop.ngfactory.ts(68,35): error TS2346: Supplied parameters do not match any signature of call target.
```
Fixes AoT compiler issue:
```
Error: Cannot determine the module for class NgFileDropDirective in node_modules/ng2-uploader/src/directives/ng-file-drop.ts!
    at analyzeAndValidateNgModules (node_modules/@angular/compiler/bundles/compiler.umd.js:12707:17)
    at OfflineCompiler.compileModules (node_modules/@angular/compiler/bundles/compiler.umd.js:12775:20)
    at CodeGenerator.codegen (/Users/chuckj/src/angular/modules/@angular/compiler-cli/src/codegen.ts:71:26)
    at codegen (tools/tasks/seed/compile.ahead.prod.ts:13:69)
    at Object.main (/storage/karl/Work/xsact/tools/@angular/tsc-wrapped/src/main.ts:44:12)
    at module.exports (tools/tasks/seed/compile.ahead.prod.ts:39:3)
    at AnonTask.run (tools/utils/seed/tasks_tools.ts:31:18)
    at Gulp.<anonymous> (tools/utils/seed/tasks_tools.ts:60:27)
    at module.exports (node_modules/orchestrator/lib/runTask.js:34:7)
    at Gulp.Orchestrator._runTask (node_modules/orchestrator/index.js:273:3)
Compilation failed
```
@jkuri
Copy link
Contributor

jkuri commented Nov 19, 2016

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants