Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Persist Tree Navigation Mode #1221

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Persist Tree Navigation Mode #1221

wants to merge 4 commits into from

Conversation

OlegMoshkovich
Copy link
Member

@OlegMoshkovich OlegMoshkovich added the bug Something isn't working label Jun 21, 2024
@OlegMoshkovich OlegMoshkovich self-assigned this Jun 21, 2024
@netlify Netlify
Copy link

netlify bot commented Jun 21, 2024 •
edited
Loading

✅ Deploy Preview for bldrs-share ready!

Name Link
🔨 Latest commit 9aacf59
🔍 Latest deploy log https://app.netlify.com/sites/bldrs-share/deploys/668d4f5de56cee0008c99f59
😎 Deploy Preview https://deploy-preview-1221--bldrs-share.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 17 (no change from production)
Accessibility: 91 (no change from production)
Best Practices: 92 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@OlegMoshkovich OlegMoshkovich marked this pull request as ready for review June 21, 2024 10:39
pablo-mayrgundter
pablo-mayrgundter requested changes Jun 21, 2024
View reviewed changes
Copy link
Member

@pablo-mayrgundter pablo-mayrgundter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests please. Unit and e2e

@OlegMoshkovich
Copy link
Member Author

added e2e tests
@pablo-mayrgundter PTAL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablo-mayrgundter pablo-mayrgundter pablo-mayrgundter requested changes

@nickcastel50 nickcastel50 Awaiting requested review from nickcastel50

Requested changes must be addressed to merge this pull request.

Assignees

@OlegMoshkovich OlegMoshkovich

Labels
bug Something isn't working
Projects
Sprints
Status: Todo
Milestone
View 100: Synchronized tree and viewp...
Development

Successfully merging this pull request may close these issues.
2 participants
@OlegMoshkovich @pablo-mayrgundter