use useEffect for key listeners on camera control panel #7827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for frigate-docs canceled.
|
|
ah, I had seen logs of trying to move the camera every once in a while and I was confused, that makes sense. Thanks! |
NickM-27
approved these changes
Sep 15, 2023
|
Need to tweak this a little so the linter doesn't fail. My preact is rusty 😂 |
|
Should be good to go now. |
blakeblackshear
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PTZ camera controls on birdseye and the individual camera components has a key listener that was triggering after the component was unmounted (when moving from birdseye to editing the config, for example).
I was able to reproduce the issue on both Safari and Firefox. Use the plus or minus keys to zoom in/out, then navigate to the config editor and type a dash.
This PR moves the keyup and keydown listeners into callbacks and implements useEffect.