-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GenAI: add ability to save JPGs sent to provider #15643
base: dev
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for frigate-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Curious what the other maintainers would say, but this is more of a debug feature in my opinion and shouldn't be user-facing through the config because it has the potential to write a lot of images with no automated cleanup mechanism. Perhaps it can be something like our object track debugging code, which can just be set to Line 758 in 87e7b62
|
Thank you for the review. I see what you mean. Code changes are a bit of a barrier for most though. Is there any other middle ground perhaps for enabling debugging, like env vars or a command line flag? |
If a key concern is leaving leftovers files, happy to look at implementing a clean-up when events are expired so they don't build up. |
In my opinion this is a bit different than Frigate's internal debug because the user doesn't have much control over Frigate's internal object tracking behaviors while a user has direct control over their preferred genai provider and its prompt. This is something that most users won't be using, especially after things are working in a satisfactory manner. This is a debug capability as opposed to an additional UI / object information feature. Personally, I think it makes most sense as:
|
I'd also be fine if it wasn't cleaned up by default, but with the option designated as a debug feature it will be more clear that this is a user function and not a default frigate function |
I'm fine with that too. I'd also prefer to leave it out of the main genai docs and only keep it in the reference config, like other options we provide. |
Proposed change
This adds a config option
save_thumbnails
to GenAI config, which will write JPGs out to the clips directory. It's disabled by default.Purpose is to help debug GenAI results. I'm already seeing some interesting things like multiple blank thumbnails being sent.
Type of change
Additional information
Checklist
ruff format frigate
)