Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #7944: Adds tls_insecure to the onvif configuration #15603

Merged
merged 2 commits into from
Dec 19, 2024

Conversation

gabrielbiasi
Copy link
Contributor

Proposed change

This change adds a new boolean configuration called tls_insecure to cameras.*.onvif allowing the TLS verification to be skipped when connecting to the ONVIF server within the camera device.

Some cameras have weird requirements and only expose an HTTPS server using a self-signed certificate for the web service. This change will fix the request on #7944, helping folks with this kind of requirement.

This value will be False by default, which means that TLS will be verified, but users can opt to disable this verification by setting tls_insecure: True.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code
  • Documentation Update

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • The code has been formatted using Ruff (ruff format frigate)

Copy link

netlify bot commented Dec 19, 2024

Deploy Preview for frigate-docs ready!

Name Link
🔨 Latest commit bc4a186
🔍 Latest deploy log https://app.netlify.com/sites/frigate-docs/deploys/676458632540dc0008b16cfe
😎 Deploy Preview https://deploy-preview-15603--frigate-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@NickM-27 NickM-27 merged commit ddfe8f3 into blakeblackshear:dev Dec 19, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option to disable TLS certificate validation of Onvif connection
3 participants