Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize handling of config files #15451

Merged
merged 3 commits into from
Dec 12, 2024
Merged

Standardize handling of config files #15451

merged 3 commits into from
Dec 12, 2024

Conversation

NickM-27
Copy link
Collaborator

@NickM-27 NickM-27 commented Dec 12, 2024

Proposed change

The code to load the config file was duplicated and overall inconsistent. This PR moves the code to the config util to reduce duplicated code and enforce config loading to be consistent.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code
  • Documentation Update

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • The code has been formatted using Ruff (ruff format frigate)

Copy link

netlify bot commented Dec 12, 2024

Deploy Preview for frigate-docs canceled.

Name Link
🔨 Latest commit 8f9280d
🔍 Latest deploy log https://app.netlify.com/sites/frigate-docs/deploys/675a2c3e75fcbc00080d6efa

@NickM-27 NickM-27 merged commit 0e3fb6c into dev Dec 12, 2024
13 checks passed
@NickM-27 NickM-27 deleted the config-loading branch December 12, 2024 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants