Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor event cleanup to consider review severity #15415

Merged
merged 5 commits into from
Dec 9, 2024
Merged

Conversation

NickM-27
Copy link
Collaborator

@NickM-27 NickM-27 commented Dec 9, 2024

Proposed change

Keep track of the max review severity for an event and expire has_clip based on that

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code
  • Documentation Update

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • The code has been formatted using Ruff (ruff format frigate)

Copy link

netlify bot commented Dec 9, 2024

Deploy Preview for frigate-docs canceled.

Name Link
🔨 Latest commit d1d0039
🔍 Latest deploy log https://app.netlify.com/sites/frigate-docs/deploys/675708db26ea2b0008a5e238

@NickM-27 NickM-27 merged commit 0b9c4c1 into dev Dec 9, 2024
13 checks passed
@NickM-27 NickM-27 deleted the event-cleanup branch December 9, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants