Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix regex for cookie_name to be general snake case #14854

Merged

Conversation

bazylhorsey
Copy link
Contributor

@bazylhorsey bazylhorsey commented Nov 8, 2024

Proposed change

cookie_name doesn't work as expected. Even when using the one supplied in the full reference config I got config errors. The new pattern is general snakecase

Fixes #14644

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code
  • Documentation Update

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • The code has been formatted using Ruff (ruff format frigate)

Copy link

netlify bot commented Nov 8, 2024

Deploy Preview for frigate-docs canceled.

Name Link
🔨 Latest commit cfe15f4
🔍 Latest deploy log https://app.netlify.com/sites/frigate-docs/deploys/673b863deccaf200086a8644

Co-authored-by: Blake Blackshear <[email protected]>
@NickM-27 NickM-27 merged commit 66f71ae into blakeblackshear:dev Nov 18, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cookie_name Validation Regex
3 participants