Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI tweaks #12297

Merged
merged 11 commits into from
Jul 8, 2024
Merged

UI tweaks #12297

merged 11 commits into from
Jul 8, 2024

Conversation

hawkeye217
Copy link
Collaborator

@hawkeye217 hawkeye217 commented Jul 4, 2024

  • Use full resolution aspect for main camera style in history view
  • Only check for offline cameras after 60s of uptime
  • Fix bug introduced in Ensure MSE onPlaying always gets called, even if loadeddata never fires #12271 - loadeddata is fired when the player can render the first frame, progress is fired as the player begins loading data, even when the first frame may not be renderable yet. So by calling onPlaying in onProgress, this sometimes caused the player to be shown before the first frame was rendered, thus showing black for a brief second. For users who have playback issues because of codec issues or bad cameras (like the user in [Bug]: upgraded to v0.14Beta now Camera Live View Not Working #12047), onPlaying will still be called after the player has accrued at least 3 seconds of buffered data.
  • Disable audio button in single Live view when an error condition switches the player from restreamed to jsmpeg
  • Portal AlertDialog so that it shows when in fullscreen, fixes [Bug]: Using 'Submit frame to Frigate+' while in full screen causes dialog in background, appears frozen #12303
  • Use a ref instead of a state and clear timeout in AutoUpdatingCameraImage. Using timeoutId as a state caused the entire component to re-render unnecessarily. Also, handleLoad might be called multiple times in quick succession, which could lead to multiple timeouts being set and some of them not being cleared correctly. This caused multiple re-renders which happened faster than the specified reloadInterval. The fix was to add a clearTimeout in handleLoad before reassigning the ref.
  • When using the Calendar component, selecting a day from a previous month, closing the dropdown, and then reopening the dropdown would not cause the calendar to default to the selected day's month. The fix uses the defaultMonth prop and adds a key to force a re-render when pressing the reset button.
  • Use the default cursor style in the mask/zone editor unless actively editing a zone/mask.

Copy link

netlify bot commented Jul 4, 2024

Deploy Preview for frigate-docs canceled.

Name Link
🔨 Latest commit 105986f
🔍 Latest deploy log https://app.netlify.com/sites/frigate-docs/deploys/668be48dd35639000891a353

@hawkeye217 hawkeye217 changed the title Use full resolution aspect for main camera style in history view UI tweaks Jul 4, 2024
@NickM-27 NickM-27 merged commit 0ce596e into dev Jul 8, 2024
13 checks passed
@NickM-27 NickM-27 deleted the recording-aspect branch July 8, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants