-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI tweaks #12297
Merged
Merged
UI tweaks #12297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for frigate-docs canceled.
|
hawkeye217
changed the title
Use full resolution aspect for main camera style in history view
UI tweaks
Jul 4, 2024
NickM-27
reviewed
Jul 5, 2024
NickM-27
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
loadeddata
is fired when the player can render the first frame,progress
is fired as the player begins loading data, even when the first frame may not be renderable yet. So by callingonPlaying
inonProgress
, this sometimes caused the player to be shown before the first frame was rendered, thus showing black for a brief second. For users who have playback issues because of codec issues or bad cameras (like the user in [Bug]: upgraded to v0.14Beta now Camera Live View Not Working #12047),onPlaying
will still be called after the player has accrued at least 3 seconds of buffered data.AutoUpdatingCameraImage
. UsingtimeoutId
as a state caused the entire component to re-render unnecessarily. Also,handleLoad
might be called multiple times in quick succession, which could lead to multiple timeouts being set and some of them not being cleared correctly. This caused multiple re-renders which happened faster than the specifiedreloadInterval
. The fix was to add aclearTimeout
inhandleLoad
before reassigning the ref.Calendar
component, selecting a day from a previous month, closing the dropdown, and then reopening the dropdown would not cause the calendar to default to the selected day's month. The fix uses thedefaultMonth
prop and adds a key to force a re-render when pressing the reset button.